chore(ci): add rustfmt to codecov & exclude fuzz from workspace #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @davidkern, thanks for your PR! I currently don't have enough time to review this PR, but I'll take a look at when possible :-) |
|
Sorry for the delayed review, looks great, thanks! |
jeertmans
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While adding tests for the safe-only code PR, I noticed that the code coverage action hasn't been able to complete successfully for a while.
Originally this was caused by rustfmt not being available in the container. So this installs it before running coverage.
Additionally, the new fuzz crate was interacting poorly with the other projects in the workspace, causing link errors for both the coverage action and when running
cargo build --workspace. This is because afl crates must be built withcargo afl buildso they can link properly. Excluding the fuzz crate from the workspace fixes both issues and also makes sure the fuzzing exports aren't inadvertently enabled on the codegen crate outside of running a fuzz.